Re: [PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures
From: Christoph Hellwig <hch@lst.de>
Date: 2021-11-03 16:05:56
Also in:
linux-block, linux-scsi, lkml
From: Christoph Hellwig <hch@lst.de>
Date: 2021-11-03 16:05:56
Also in:
linux-block, linux-scsi, lkml
On Wed, Nov 03, 2021 at 05:21:48AM -0700, Luis Chamberlain wrote:
If nd_integrity_init() fails we'd get del_gendisk() called, but that's not correct as we should only call that if we're done with device_add_disk(). Fix this by providing unwinding prior to the devm call being registered and moving the devm registration to the very end. This should fix calling del_gendisk() if nd_integrity_init() fails. I only spotted this issue through code inspection. It does not fix any real world bug.
Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> Should this grow a Fixes tag for the commit adding the problem?