Re: [PATCH v2 08/13] z2ram: add error handling support for add_disk()

[PATCH v2 00/13] block: add_disk() error handling stragglers · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 02/13] nvdimm/btt: use goto error labels on btt_blk_init() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 02/13] nvdimm/btt: use goto error labels on btt_blk_init() · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures · Christoph Hellwig <hch@lst.de> · 2021-11-03
Re: [PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 08/13] z2ram: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 08/13] z2ram: add error handling support for add_disk() · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 13/13] block: add __must_check for *add_disk*() callers · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 06/13] nvdimm/pmem: cleanup the disk if pmem_release_disk() is yet assigned · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 06/13] nvdimm/pmem: cleanup the disk if pmem_release_disk() is yet assigned · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 12/13] block: make __register_blkdev() return an error · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 12/13] block: make __register_blkdev() return an error · Christoph Hellwig <hch@lst.de> · 2021-11-03
Re: [PATCH v2 12/13] block: make __register_blkdev() return an error · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 12/13] block: make __register_blkdev() return an error · Christoph Hellwig <hch@lst.de> · 2021-11-03
Re: [PATCH v2 12/13] block: make __register_blkdev() return an error · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 10/13] mtd/ubi/block: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 10/13] mtd/ubi/block: add error handling support for add_disk() · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 09/13] block/sunvdc: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 09/13] block/sunvdc: add error handling support for add_disk() · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 01/13] nvdimm/btt: do not call del_gendisk() if not needed · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 01/13] nvdimm/btt: do not call del_gendisk() if not needed · Christoph Hellwig <hch@lst.de> · 2021-11-03
Re: [PATCH v2 01/13] nvdimm/btt: do not call del_gendisk() if not needed · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 05/13] nvdimm/blk: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 05/13] nvdimm/blk: add error handling support for add_disk() · Christoph Hellwig <hch@lst.de> · 2021-11-03
[PATCH v2 11/13] ataflop: remove ataflop_probe_lock mutex · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
[PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03
Re: [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk() · Christoph Hellwig <hch@lst.de> · 2021-11-03
Re: [PATCH v2 00/13] block: add_disk() error handling stragglers · Luis Chamberlain <mcgrof@kernel.org> · 2021-11-03

From: Christoph Hellwig <hch@lst.de>
Date: 2021-11-03 16:07:12
Also in: linux-block, linux-scsi, lkml

On Wed, Nov 03, 2021 at 05:21:52AM -0700, Luis Chamberlain wrote:

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling. Only the disk is cleaned up inside
z2ram_register_disk() as the caller deals with the rest.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help