Re: [PATCH V12 06/20] block: rename bvec helpers

From
Miguel Ojeda <hidden>
Date
2018-11-26 08:17:16
Also in
dm-devel, linux-bcache, linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-xfs, lkml
Reply to
Ming Lei, 2018-11-26
On Mon, Nov 26, 2018 at 3:20 AM Ming Lei [off-list ref] wrote:
We will support multi-page bvec soon, and have to deal with
single-page vs multi-page bvec. This patch follows Christoph's
suggestion to rename all the following helpers:

        for_each_bvec
        bvec_iter_bvec
        bvec_iter_len
        bvec_iter_page
        bvec_iter_offset

into:
        for_each_segment
        segment_iter_bvec
        segment_iter_len
        segment_iter_page
        segment_iter_offset

so that these helpers named with 'segment' only deal with single-page
bvec, or called segment. We will introduce helpers named with 'bvec'
for multi-page bvec.

bvec_iter_advance() isn't renamed becasue this helper is always operated
on real bvec even though multi-page bvec is supported.

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <redacted>
---
 .clang-format                  |  2 +-
Acked-by: Miguel Ojeda <redacted>

Cheers,
Miguel
Thread (48 messages) 48 messages, 5 authors, last reply 2018-11-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help