Re: [PATCH V12 09/20] block: use bio_for_each_bvec() to compute multi-page bvec count

From
Christoph Hellwig <hch@lst.de>
Date
2018-11-26 13:11:20
Also in
dm-devel, linux-bcache, linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-xfs, lkml
Reply to
Ming Lei, 2018-11-26
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Nitpick below:
quoted hunk ↗ jump to hunk
+{
+	unsigned len = bv->bv_len;
+	unsigned total_len = 0;
+	unsigned new_nsegs = 0, seg_size = 0;
+
+	/*
+	 * Multipage bvec may be too big to hold in one segment,
+	 * so the current bvec has to be splitted as multiple
+	 * segments.
+	 */
Please use up all 80 chars in a line.
Thread (48 messages) 48 messages, 5 authors, last reply 2018-11-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help