Re: [PATCH V12 17/20] block: always define BIO_MAX_PAGES as 256
From: Omar Sandoval <osandov@osandov.com>
Date: 2018-11-26 22:44:39
Also in:
dm-devel, linux-bcache, linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-xfs, lkml
On Mon, Nov 26, 2018 at 10:17:17AM +0800, Ming Lei wrote:
Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to increase BIO_MAX_PAGES for it. CONFIG_THP_SWAP needs to split one THP into normal pages and adds them all to one bio. With multipage-bvec, it just takes one bvec to hold them all. Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Omar Sandoval <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Ming Lei <redacted> --- include/linux/bio.h | 8 -------- 1 file changed, 8 deletions(-)diff --git a/include/linux/bio.h b/include/linux/bio.h index 5505f74aef8b..7be48c55b14a 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h@@ -34,15 +34,7 @@ #define BIO_BUG_ON #endif -#ifdef CONFIG_THP_SWAP -#if HPAGE_PMD_NR > 256 -#define BIO_MAX_PAGES HPAGE_PMD_NR -#else #define BIO_MAX_PAGES 256 -#endif -#else -#define BIO_MAX_PAGES 256 -#endif #define bio_prio(bio) (bio)->bi_ioprio #define bio_set_prio(bio, prio) ((bio)->bi_ioprio = prio)-- 2.9.5