Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()

From: Paul Bolle <hidden>
Date: 2016-09-29 21:42:59
Also in: dm-devel, kernel-janitors, lkml
Reply to: Joe Perches, 2016-09-29

On Thu, 2016-09-29 at 14:21 -0700, Joe Perches wrote:

quoted

It doesn't matter match either way to me.

Why does this stop you fixing an apparently wrong checkpatch rule,
crude as parts of it are (ie, uppercase identifier must be a
constant)?

It doesn't.  It just doesn't matter much (match) to me.

Joe, please.

I've recently ping-ponged with the kernel's "resident wrong bot of the
day" over this very rule (kmalloc_array() is safer than kmalloc(), so
change your driver now!). Could we just give wrong bots a bit less
ammunition whenever that's feasible?

Even if you don't care about my ping-pong experiences: this checkpatch
test is broken, please just fix it!


Paul Bolle

(off-list ancestor, not in this archive)
SF Markus Elfring · 2016-09-29
[PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · SF Markus Elfring · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Joe Perches · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Joe Perches · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Joe Perches · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Joe Perches · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Joe Perches · 2016-09-29
Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() · Paul Bolle · 2016-09-29
Re: dm snapshot: Use kmalloc_array() in init_origin_hash() ? · SF Markus Elfring · 2016-09-30
Re: dm snapshot: Use kmalloc_array() in init_origin_hash() · SF Markus Elfring · 2016-09-29
Re: dm snapshot: Use kmalloc_array() in init_origin_hash() · Theodore Ts'o · 2016-09-29
[PATCH 02/10] dm snapshot: Delete two error messages for a failed memory allocation · SF Markus Elfring · 2016-09-29
[PATCH 03/10] dm snapshot: Delete an unnecessary variable initialisation in snapshot_map() · SF Markus Elfring · 2016-09-29
[PATCH 04/10] dm snapshot: Rename a jump label in pending_complete() · SF Markus Elfring · 2016-09-29
[PATCH 05/10] dm snapshot: Delete unnecessary variable initialisations in pending_complete() · SF Markus Elfring · 2016-09-29
[PATCH 06/10] dm snapshot: Delete an unnecessary variable initialisation in snapshot_ctr() · SF Markus Elfring · 2016-09-29
[PATCH 07/10] dm snapshot: Delete an unnecessary variable initialisation in merge_callback() · SF Markus Elfring · 2016-09-29
[PATCH 08/10] dm snapshot: Delete an unnecessary variable initialisation in remove_single_exception_chunk() · SF Markus Elfring · 2016-09-29
[PATCH 09/10] dm snapshot: Combine substrings for seven error messages · SF Markus Elfring · 2016-09-29
[PATCH 10/10] dm snapshot: Delete five unwanted spaces behind "list_for_each_entry" · SF Markus Elfring · 2016-09-29
View all 26 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help