Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()

From
Joe Perches <joe@perches.com>
Date
2016-09-29 20:56:41
Also in
dm-devel, kernel-janitors, lkml
Reply to
Paul Bolle, 2016-09-29
On Thu, 2016-09-29 at 22:39 +0200, Paul Bolle wrote:
On Thu, 2016-09-29 at 13:24 -0700, Joe Perches wrote:
quoted
On Thu, 2016-09-29 at 21:43 +0200, Paul Bolle wrote:
quoted
Why doesn't that regex match on "ORIGIN_HASH_SIZE"?
It does match.
If that regex does match, it being part of a negative test, the
specific checkpatch rule should be silent, shouldn't it?
'cause I forgot to trim() the original $4 and $10 matches.

Oh well.

It doesn't matter match either way to me.

The case for the unnecessary multiply with <= gcc 4.8 was
removed with:

commit 91c6a05f72a996bee5133e76374ab3ad7d3b9b72
Author: Alexey Dobriyan [off-list ref]
Date:   Tue Jul 26 15:22:08 2016 -0700

    mm: faster kmalloc_array(), kcalloc()
    
    When both arguments to kmalloc_array() or kcalloc() are known at compile
    time then their product is known at compile time but search for kmalloc
    cache happens at runtime not at compile time.
    
    Link: http://lkml.kernel.org/r/20160627213454.GA2440@p183.telecom.by (local)
    Signed-off-by: Alexey Dobriyan [off-list ref]
    Cc: Christoph Lameter [off-list ref]
    Cc: Pekka Enberg [off-list ref]
    Cc: David Rientjes [off-list ref]
    Cc: Joonsoo Kim [off-list ref]
    Signed-off-by: Andrew Morton [off-list ref]
    Signed-off-by: Linus Torvalds [off-list ref]
Thread (26 messages) 26 messages, 4 authors, last reply 2016-09-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help