Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()
From: Joe Perches <joe@perches.com>
Date: 2016-09-29 20:25:00
Also in:
dm-devel, kernel-janitors, lkml
On Thu, 2016-09-29 at 21:43 +0200, Paul Bolle wrote:
On Thu, 2016-09-29 at 08:01 -0700, Joe Perches wrote:quoted
$Constant there is any number and the match regex is any upper case variable.Why doesn't that regex match on "ORIGIN_HASH_SIZE"?
It does match. Did you see my earlier email? $ ./scripts/checkpatch.pl -f drivers/md/dm-snap.c --show-types --types=alloc_with_multiply WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply #329: FILE: drivers/md/dm-snap.c:329: + _origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head), WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply #338: FILE: drivers/md/dm-snap.c:338: + _dm_origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head), total: 0 errors, 2 warnings, 2490 lines checked