Thread (51 messages) 51 messages, 9 authors, 2016-12-27

Re: [PATCH 1/3] PM suspend/hibernate: Call notifier after freezing processes

From: Rafael J. Wysocki <hidden>
Date: 2015-04-09 16:49:33
Also in: dm-devel, linux-pm, lkml

On Thursday, April 09, 2015 08:36:57 AM Pali Rohár wrote:
--nextPart2566388.gOmNIJrIqI
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Thursday 09 April 2015 02:28:41 Rafael J. Wysocki wrote:
quoted
On Sunday, April 05, 2015 07:20:17 PM Pali Roh=C3=A1r wrote:
quoted
To prevent race conditions on userspace processes with I/O
some taks must be called after processes are freezed. This
patch adds new events which are delivered by
pm_notifier_call_chain() after freezing processes when
doing suspend or hibernate action.
=20
Signed-off-by: Pali Roh=C3=A1r <redacted>
=20
Please don't add more notifiers.  Just call whatever you need
directly from where you need to call that.
=20
If that is device-related, try to use device PM
suspend/hibernate callbacks instead.
=20
Hi! It is not possible to use any exiting pm notifiers! This is=20
reason why I added new ones. As I wrote wiping dm crypt keys must=20
be done *after* userspace processes are freezed to prevent race=20
conditions...
I'm not talking about using the existing notifiers.  I'm talking about
calling the function you need to call directly from a suitable place
in the system suspend code.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help