On Tue, Sep 4, 2018 at 2:15 AM Bjorn Andersson
[off-list ref] wrote:

On Thu 30 Aug 12:23 PDT 2018, Amit Kucheria wrote:

quoted

On Tue, Aug 28, 2018 at 7:08 PM, Amit Kucheria [off-list ref] wrote:

quoted

The SROT registers are initialised by the secure firmware at boot. We
don't have write access to the registers. Check if the block is enabled
before continuing.

Signed-off-by: Amit Kucheria <redacted>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/thermal/qcom/tsens-common.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index 0b8a793f15f4..d250b757d1f0 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c

@@ -12,6 +12,11 @@
 #include <linux/regmap.h>
 #include "tsens.h"

+/* SROT */
+#define CTRL_OFFSET            0x4

This OFFSET is not constant across the TSENS family and breaks atleast
one platform in the test below. I have a patch to fix this for all
platforms, will post it after a bit more testing.

Afaict the other 10 patches can be merged independently of this patch.

So please make the minor updates and resend them as a separate series,
with the acks/reviews, to make it easier for Eduardo to just pick them.

Will do.