Thread (20 messages) 20 messages, 2 authors, 2018-09-06

Re: [PATCH v2 05/11] thermal: tsens: Get rid of dead code

From: Bjorn Andersson <hidden>
Date: 2018-09-03 20:18:49
Also in: linux-arm-msm, lkml

On Tue 28 Aug 06:38 PDT 2018, Amit Kucheria wrote:
hw_id is dynamically allocated but not used anywhere. Get rid of dead
code.

Signed-off-by: Amit Kucheria <redacted>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Good catch.

Reviewed-by: Bjorn Andersson <redacted>

Regards,
Bjorn
quoted hunk ↗ jump to hunk
---
 drivers/thermal/qcom/tsens.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 90bb431cf740..9a8e8f7b4ae1 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -80,11 +80,6 @@ static int tsens_register(struct tsens_device *tmdev)
 {
 	int i;
 	struct thermal_zone_device *tzd;
-	u32 *hw_id, n = tmdev->num_sensors;
-
-	hw_id = devm_kcalloc(tmdev->dev, n, sizeof(u32), GFP_KERNEL);
-	if (!hw_id)
-		return -ENOMEM;
 
 	for (i = 0;  i < tmdev->num_sensors; i++) {
 		tmdev->sensor[i].tmdev = tmdev;
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help