On 08/16/2018 03:37 PM, Quentin Perret wrote:

quoted

quoted

IMHO, if this is something which should not happen at all, a BUG_ON() is the
right thing to do here.

I don't agree on that. I agree it should not happen but since it's a
recoverable error it think we should not panic.

FWIW, if this is a recoverable error, I think Linus will agree with
Patrick on this one :-)

https://lkml.org/lkml/2016/10/4/1

Yeah, not really agreeing here that this is a recoverable error. 
Besides, we only consider under-run here, what about over-run?

Currently this warning doesn't hit and if the code will be changed and 
it hits, I still find a BUG_ON more appealing here ...

So this error scenario can happen over and over again and we always 
recover from ? The important thing is that we find the culprit for this 
behaviour as fast as possible ...

Warning or bug, at least a stack trace is necessary.