Thread (22 messages) 22 messages, 5 authors, 2016-06-01

Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

From: Chanwoo Choi <hidden>
Date: 2016-06-01 11:33:35
Also in: kernel-janitors, linux-samsung-soc

Hi Myungjoo,

On Wed, Jun 1, 2016 at 7:25 PM, MyungJoo Ham [off-list ref] wrote:
On Thu, May 26, 2016 at 3:45 PM, Dan Carpenter [off-list ref] wrote:
quoted
Smatch complains because platform_get_resource() returns NULL on error
and not an error pointer so the check is wrong.  Julia Lawall pointed
out that normally we don't check these, because devm_ioremap_resource()
has a check for NULL.

Signed-off-by: Dan Carpenter <redacted>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Queued in fixes branch to be sent with other fixes for RCx.

I already reviewed this patch. Also, the merged patch[1] don't include
the my reviewed-by tag.
I'd like you to add my reviewed-by tag again.

[1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=fixes&id=44a3c02256bb69b2a20f55d2bd77c5a2fd20bc52

Regards,
Chanwoo Choi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help