Thread (22 messages) 22 messages, 5 authors, 2016-06-01

Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

From: Julia Lawall <hidden>
Date: 2016-05-26 14:15:21
Also in: kernel-janitors, linux-samsung-soc


On Thu, 26 May 2016, Chanwoo Choi wrote:
On Thu, May 26, 2016 at 10:56 PM, Dan Carpenter
[off-list ref] wrote:
quoted
On Thu, May 26, 2016 at 10:46:26PM +0900, Chanwoo Choi wrote:
quoted
On Thu, May 26, 2016 at 8:56 PM, Dan Carpenter [off-list ref] wrote:
quoted
On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
quoted
I don't recommend that you mention the name of engineer on patch description
directly.
This really is normal.  I've been mentioned over 100 times in commit
messages like 7051924f771 (xillybus: Move out of staging).
I'm still reluctant to use the name on description.
I understand that but I don't understand why, though.  Anyway, aren't
forwarding this to someone?  You can change it to say whatever you want.
Because if the name without any unique email address is included in
the description,
I sent a Reviewed-by, so this issue is solved.

julia
I think that it is not appropriate. Always, the information should
include the email address.
So, I just prefer to use the Suggested-by or the different kind of tag
with [id: explanation].

But, I'll stop about it because it is not critical issue.
It depend on what is the preferred method to add the information.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help