Thread (22 messages) 22 messages, 5 authors, 2016-06-01

Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2016-05-26 10:16:03
Also in: kernel-janitors, linux-samsung-soc

On 2016년 05월 26일 19:02, Dan Carpenter wrote:
On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
quoted
I don't recommend that you mention the name of engineer on patch description
directly. Except for this comment, looks good to me.
I always feel it's nicer to give credit.  Plus Julia is already a well
known kernel dev and this was a pubic list.  (I wouldn't give credit if
she had sent hurtful comments about my spelling to me privately, for
example).
If you want to give credit as you mentioned, you can add the acked-by
or signed-off for Julia. But, usually, the patch description don't
include the engineer's name directly.

Thanks,
Chanwoo Choi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help