On Fri, Mar 4, 2016 at 11:50 AM, Juri Lelli [off-list ref] wrote:

Hi Rafael,

On 04/03/16 04:18, Rafael J. Wysocki wrote:

[...]

quoted

+/**
+ * cpufreq_update_util - Take a note about CPU utilization changes.
+ * @time: Current time.
+ * @util: CPU utilization.
+ * @max: CPU capacity.
+ *
+ * This function is called on every invocation of update_load_avg() on the CPU
+ * whose utilization is being updated.
+ *
+ * It can only be called from RCU-sched read-side critical sections.
+ */
+void cpufreq_update_util(u64 time, unsigned long util, unsigned long max)
+{
+     struct freq_update_hook *hook;
+
+#ifdef CONFIG_LOCKDEP
+     WARN_ON(debug_locks && !rcu_read_lock_sched_held());
+#endif
+
+     hook = rcu_dereference(*this_cpu_ptr(&cpufreq_freq_update_hook));

Small fix. You forgot to change this to rcu_dereference_sched() (you
only fixed that in 01/10).

Yup, thanks!

I had to propagate the change throughout the queue and forgot about
the last step.

I'll send an updated patch shortly.

Thanks,
Rafael