On Tue, Jul 28, 2015 at 02:21:33PM +0200, Pavel Machek wrote:

Hi!

quoted

 int cmdline_find_option_bool(const char *option);
 #endif
 
+#if CONFIG_RANDOMIZE_BASE

Not ifdef?

quoted

+extern u16 i8254(void);

That's rather poor name for global function...

This i8254 function only used by aslr and efi_random.
I will keep this name for do not change codes in aslr for naming.

quoted

 #if CONFIG_RANDOMIZE_BASE

Ok, maybe not, but I'm confused.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thanks a lot!
Joey Lee