Re: [RFC PATCH 02/16] x86/efi: Add get and set variable to EFI services pointer table
From: joeyli <hidden>
Date: 2015-07-31 10:15:21
Also in:
linux-efi, lkml
From: joeyli <hidden>
Date: 2015-07-31 10:15:21
Also in:
linux-efi, lkml
On Thu, Jul 30, 2015 at 04:19:58PM +0100, Matt Fleming wrote:
On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote:quoted
Add get variable and set variable function to EFI services pointer table for supporting later functions of hibernate signature verification to keep the HMAC key in efi boot service veriable. Signed-off-by: Lee, Chun-Yi <jlee-IBi9RG/b67k@public.gmane.org>Maybe mention that we want to be able to read/write variables from within the EFI boot stub? That's really why you want to add {get,set}_variable pointers.
I will add more detail for accessing efi boot service variable is because that will not touched by unauthenticated codes.
s/veriable/variable/
I will fix the typo.
Rest of the patch looks good.
Thanks a lot! Joey Lee