Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver.
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2012-10-31 02:33:57
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2012-11-06 · Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver. · Hongbo Zhang <hidden>
- 2012-11-06 · Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver. · Hongbo Zhang <hidden>
- 2012-11-01 · RE: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver. · Zhang, Rui <hidden>
Sorry for late comments :( On 30 October 2012 22:19, hongbo.zhang [off-list ref] wrote:
From: "hongbo.zhang" <redacted> This diver is based on the thermal management framework in thermal_sys.c. A
s/diver/driver
quoted hunk ↗ jump to hunk
thermal zone device is created with the trip points to which cooling devices can be bound, the current cooling device is cpufreq, e.g. CPU frequency is clipped down to cool the CPU, and other cooling devices can be added and bound to the trip points dynamically. The platform specific PRCMU interrupts are used to active thermal update when trip points are reached. Signed-off-by: hongbo.zhang <redacted> --- .../devicetree/bindings/thermal/db8500-thermal.txt | 40 ++ drivers/thermal/Kconfig | 20 + drivers/thermal/Makefile | 2 + drivers/thermal/db8500_cpufreq_cooling.c | 108 +++++ drivers/thermal/db8500_thermal.c | 531 +++++++++++++++++++++ include/linux/platform_data/db8500_thermal.h | 38 ++ 6 files changed, 739 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/db8500-thermal.txt create mode 100644 drivers/thermal/db8500_cpufreq_cooling.c create mode 100644 drivers/thermal/db8500_thermal.c create mode 100644 include/linux/platform_data/db8500_thermal.hdiff --git a/Documentation/devicetree/bindings/thermal/db8500-thermal.txt b/Documentation/devicetree/bindings/thermal/db8500-thermal.txt new file mode 100644 index 0000000..cab6916 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/db8500-thermal.txt@@ -0,0 +1,40 @@ +* ST-Ericsson DB8500 Thermal + +** Thermal node properties: + +- compatible : "stericsson,db8500-thermal"; +- reg : address range of the thermal sensor registers; +- interrupts : interrupts generated from PRCMU; +- interrupt-names : "IRQ_HOTMON_LOW" and "IRQ_HOTMON_HIGH";
Just mention here that below properties are optional or required.
+- num-trips : number of total trip points; +- tripN-temp : temperature of trip point N, should be in ascending order; +- tripN-type : type of trip point N, should be one of "active" "passive" "hot" "critical"; +- tripN-cdev-num : number of the cooling devices which can be bound to trip point N; +- tripN-cdev-nameM : name of the No. M cooling device of trip point N;
quoted hunk ↗ jump to hunk
diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
+static int db8500_thermal_match_cdev(struct thermal_cooling_device *cdev,
+ struct db8500_trip_point *trip_points)
+{
+ int i;
+ char *cdev_name;
+
+ if (!strlen(cdev->type))
+ return -EINVAL;
+
+ for (i = 0; i < COOLING_DEV_MAX; i++) {
+ cdev_name = trip_points->cdev_name[i];
+ if (!strcmp(cdev_name, cdev->type))You can actually remove cdev_name variable. and use if (!strcmp(trip_points->cdev_name[i], cdev->type))
+ return 0; + } + + return -ENODEV; +}
+#ifdef CONFIG_OF
+static struct db8500_thsens_platform_data*
+ db8500_thermal_parse_dt(struct platform_device *pdev)
+{+ for (j = 0; j < tmp_data; j++) {
+ sprintf(prop_name, "trip%d-cdev-name%d", i, j);
+ if (of_property_read_string(np, prop_name, &tmp_str))
+ goto err_parse_dt;
+
+ if (strlen(tmp_str) > THERMAL_NAME_LENGTH)
+ goto err_parse_dt;
+
+ strcpy(ptrips->trip_points[i].cdev_name[j], tmp_str);want to check if it is copied or not??
+ } + } + return ptrips; + +err_parse_dt: + dev_err(&pdev->dev, "Parsing device tree data error.\n"); + return NULL; +}
After these please add my: Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>