RE: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2025-07-23 12:45:23
Also in:
linux-arm-kernel, linux-devicetree, linux-samsung-soc, lkml
-----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Wednesday, July 23, 2025 2:13 PM To: Pritam Manohar Sutar <redacted>; 'Krzysztof Kozlowski' [off-list ref] Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
[snip]
quoted
quoted
quoted
quoted
quoted
Ok got it. Will change supplies name as below avdd075_usb => avdd075-usb avdd18_usb20 => avdd18-usb20 avdd33_usb20 => avdd33-usb20 Confirm the above change that is meant in terms of DTS style.Yes. I have doubts that actual supplies have suffix usb20. Are there more than one avdd18 for this block?Yes, there are more than one vdd18 supplies for this block.And their names are?quoted
Re-analysed your comment on adding new supplies. Going to re-use existing supplies as mentioned below, rather than introducing new supplies dvdd-usb20-supply => for 0.75v vddh-usb20-supply => for 1.8v vdd33-usb20-supply => for 3.3vYou just expect us to guess whether this is correct...Sorry about not being clear so far. V920 needs three supplies, 0.75v, 1.8v and 3.3v for USB PHY The naming convention used in the schematic are avdd075-usb, avdd18_usb20, avdd33_usb20. However, PHY's user manual just mentions DVDD, VDD33 and VDD18.Then dvdd, vdd33 and vdd18.quoted
Since GS101 binding already using supply names similar to what ismentioned in the PHY user manual. GS101 has USB 2.0 and DP, thus the suffix made some sense. I think you have only USB 2.0, that's why I question the suffix.
I cross checked the schematic of v920 SADK, this is a combo PHY which support USB-3.0 as well. @ Pritam Schema should capture all the supplies including USB-3.0, similar to GS101 (which has USB2.0 and DP combo). So that would be as below: dvdd075-usb20-supply vdd18-usb20-supply vdd33-usb20-supply dvdd075-usb30-supply vdd18-usb30-supply please cross check the supply at your end and do the needful.
Best regards, Krzysztof
-- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy