Re: [PATCH 5/7] nvme: expose subsystem type in sysfs attribute 'subtype'
From: Hannes Reinecke <hare@suse.de>
Date: 2021-10-12 13:44:17
On 10/12/21 3:10 PM, Christoph Hellwig wrote:
On Wed, Sep 22, 2021 at 10:02:56AM +0200, Daniel Wagner wrote:quoted
On Wed, Sep 22, 2021 at 08:35:23AM +0200, Hannes Reinecke wrote:quoted
+static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype); + #define nvme_subsys_show_str_function(field) \ static ssize_t subsys_##field##_show(struct device *dev, \ struct device_attribute *attr, char *buf) \@@ -2618,6 +2636,7 @@ static struct attribute *nvme_subsys_attrs[] = { &subsys_attr_serial.attr, &subsys_attr_firmware_rev.attr, &subsys_attr_subsysnqn.attr, + &subsys_attr_subtype.attr,Shouldn't this be subsystype to stay consistent with subsysnqn?Hannes? I've aplied the patch for now, but the above seems like a useful fixup to fold in.
I don't really care. Should I send you a patch to update it? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme