Thread (21 messages) 21 messages, 6 authors, 2021-10-12

Re: [PATCH 5/7] nvme: expose subsystem type in sysfs attribute 'subtype'

From: Daniel Wagner <hidden>
Date: 2021-09-22 08:03:20

On Wed, Sep 22, 2021 at 08:35:23AM +0200, Hannes Reinecke wrote:
quoted hunk ↗ jump to hunk
+static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype);
+
 #define nvme_subsys_show_str_function(field)				\
 static ssize_t subsys_##field##_show(struct device *dev,		\
 			    struct device_attribute *attr, char *buf)	\
@@ -2618,6 +2636,7 @@ static struct attribute *nvme_subsys_attrs[] = {
 	&subsys_attr_serial.attr,
 	&subsys_attr_firmware_rev.attr,
 	&subsys_attr_subsysnqn.attr,
+	&subsys_attr_subtype.attr,

Shouldn't this be subsystype to stay consistent with subsysnqn?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help