Thread (14 messages) 14 messages, 8 authors, 2012-02-20

Re: [PATCH] mm: add config NUMA stub to all architectures

From: Michal Marek <hidden>
Date: 2012-02-20 14:24:37
Also in: linux-kbuild, lkml

On 20.2.2012 00:21, Arnaud Lacombe wrote:
On Sun, Feb 19, 2012 at 1:12 PM, Randy Dunlap [off-list ref] wrote:
quoted
On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote:
quoted
On Fri, Feb 17, 2012 at 21:30, Andrew Morton[off-list ref]
 wrote:
quoted
It would be better to teach IS_ENABLED() to handle this situation.  I
don't think there's a way of doing this with cpp :(

This limitation makes IS_ENABLED pretty dangerous, doesn't it?  It
makes it very easy to introduce build breakage with unexpected Kconfig
combinations.

Indeed. Recently I discovered IS_ENABLED() and started recommending it
to people for new code. But now I've seen the CONFIG_NUMA breakage,
I no longer think this is a good recommendation.
adding Michal & linux-kbuild to cc: list.
I do not really see any way to fix this, beside having a unique
architecture-wide configuration namespace :/
Having a single namespace, or less ambitiously, having less
arch-specific config symbol definitions, would be a plus. IS_ENABLED
requiring the symbol to be defined is not bad per se, it prevents typos.

Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help