Re: [PATCH] mm: add config NUMA stub to all architectures
From: Arnaud Lacombe <hidden>
Date: 2012-02-19 23:21:29
Also in:
linux-kbuild, lkml
Hi, On Sun, Feb 19, 2012 at 1:12 PM, Randy Dunlap [off-list ref] wrote:
On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote:quoted
On Fri, Feb 17, 2012 at 21:30, Andrew Morton[off-list ref] wrote:quoted
On Fri, 17 Feb 2012 16:08:15 +0400 Konstantin Khlebnikov[off-list ref] wrote:quoted
Config NUMA must be defined for all architectures, otherwise IS_ENABLED(CONFIG_NUMA) does not work. Some arch-specific Kconfig already has this stub. This patch adds it to all remaining.It would be better to teach IS_ENABLED() to handle this situation. I don't think there's a way of doing this with cpp :( This limitation makes IS_ENABLED pretty dangerous, doesn't it? It makes it very easy to introduce build breakage with unexpected Kconfig combinations.Indeed. Recently I discovered IS_ENABLED() and started recommending it to people for new code. But now I've seen the CONFIG_NUMA breakage, I no longer think this is a good recommendation.adding Michal & linux-kbuild to cc: list.
I do not really see any way to fix this, beside having a unique architecture-wide configuration namespace :/ - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html