Thread (25 messages) 25 messages, 3 authors, 2017-02-23

Re: [PATCH RFC 2/3] libkmod: list: export list handling functions

From: Lucas De Marchi <hidden>
Date: 2017-02-13 08:05:07

On Fri, Nov 11, 2016 at 3:43 AM, Yauheni Kaliuta
[off-list ref] wrote:
The library uses list functions to create lists internally and
provides to the clients immutable lists and only functions to
traverse them.

It may be useful to create own lists in the kmod utilities, so
export functions for lists creation as well (as it's done for
arrays). The following functions affected (needed for the
following depmod modifications):

kmod_list_append()
kmod_list_remove()
kmod_list_remove_data()

The patch also adds kmod_list_data() accessor to keep the
struct kmod_list opaque.
I don't see a use for these functions outside of the tools we provide.
We don't need to export them (to external users) in order to use for
our tools.  You can just make the tools include libkmod-internal.h and
use that.

In fact since you didn't update the .sym file what will happen is that
external users will see a function in the header but won't be able to
use it since it will not be part of the .so.

Lucas De Marchi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help