Re: [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles
From: Mian Yousaf Kaukab <hidden>
Date: 2016-11-09 09:17:33
On Wed, 2016-11-09 at 04:59 +0200, Yauheni Kaliuta wrote:
Hi! It may require more serious refactoring, since there is a problem with the approach of path recording. I can get wrong output, for example, for the following graph: /* mod6 -> mod7 -> mod8 -> mod9 ^ | | --------------- | | | ----------------------- */ depmod: ERROR: Cycle detected: mod7 -> mod8 -> mod9 -> mod6 -> mod7 depmod: ERROR: Cycle detected: mod6 -> mod6 depmod: ERROR: Found 5 modules in dependency cycles! The problem is that the path is recorded "globally", not per vertex, and "wrong" mod6 is compared in "loop == m".
I agree and in the other thread Bjorn is mentioning kind of the same. BR, Yousaf