Thread (25 messages) 25 messages, 3 authors, 2017-02-23

Re: [PATCH v1 1/2] testsuite: depmod: add module dependency outside cyclic chain

From: Lucas De Marchi <hidden>
Date: 2016-11-09 00:29:31

On Tue, Nov 8, 2016 at 2:45 PM, Mian Yousaf Kaukab
[off-list ref] wrote:
Check that depmod do not report modules outside cyclic chain

Two modules f and g are added which do not have any dependency.
modules a and b are made dependent on f and g.

Signed-off-by: Mian Yousaf Kaukab <redacted>
---
Here is the output of loop dependency check test after adding this
patch:

ESTSUITE: ERR: wrong:
depmod: ERROR: Found 7 modules in dependency cycles!
depmod: ERROR: Cycle detected: mod_loop_d -> mod_loop_e -> mod_loop_d
depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_b
depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_g
depmod: ERROR: Cycle detected: mod_loop_b -> mod_loop_c -> mod_loop_a -> mod_loop_f

Buffer overflow occurs in the loop when last two lines are printed.
43 bytes buffer is allocated and 53 bytes are used.

Great!

I found this last part of the message very useful to be in the commit
message, so I moved it there.

Thanks,
Applied

Lucas De Marchi

-- 
Lucas De Marchi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help