Thread (34 messages) 34 messages, 6 authors, 2017-05-19

Re: [PATCH v5 02/11] mm: mempolicy: add queue_pages_node_check()

From: Mel Gorman <hidden>
Date: 2017-05-19 16:02:10
Also in: lkml

On Fri, May 19, 2017 at 06:43:37PM +0530, Anshuman Khandual wrote:
On 04/21/2017 09:34 AM, Anshuman Khandual wrote:
quoted
On 04/21/2017 02:17 AM, Zi Yan wrote:
quoted
From: Naoya Horiguchi <redacted>

Introduce a separate check routine related to MPOL_MF_INVERT flag.
This patch just does cleanup, no behavioral change.
Can you please send it separately first, this should be debated
and merged quickly and not hang on to the series if we have to
respin again.

Reviewed-by: Anshuman Khandual <redacted>
Mel/Andrew,

This does not have any functional changes and very much independent.
Can this clean up be accepted as is ? In that case we will have to
carry one less patch in the series which can make the review process
simpler.
As you say, there is no functional change but the helper name is vague
and gives no hint to what's it's checking for. It's somewhat tolerable as
it is as it's obvious what is being checked but the same is not true with
the helper name.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help