Re: [PATCH v5 01/11] mm: x86: move _PAGE_SWP_SOFT_DIRTY from bit 7 to bit 1
From: Anshuman Khandual <hidden>
Date: 2017-05-19 13:08:32
Also in:
lkml
From: Anshuman Khandual <hidden>
Date: 2017-05-19 13:08:32
Also in:
lkml
On 04/21/2017 02:17 AM, Zi Yan wrote:
From: Naoya Horiguchi <redacted>
pmd_present() checks _PAGE_PSE along with _PAGE_PRESENT to avoid
false negative return when it races with thp spilt
(during which _PAGE_PRESENT is temporary cleared.) I don't think that
dropping _PAGE_PSE check in pmd_present() works well because it can
hurt optimization of tlb handling in thp split.
In the current kernel, bits 1-4 are not used in non-present format
since commit 00839ee3b299 ("x86/mm: Move swap offset/type up in PTE to
work around erratum"). So let's move _PAGE_SWP_SOFT_DIRTY to bit 1.
Bit 7 is used as reserved (always clear), so please don't use it for
other purpose.
Signed-off-by: Naoya Horiguchi <redacted>
Signed-off-by: Zi Yan <redacted>+Dave Hansen +Andi Kleen Dave/Andi/Kiril, Does this change looks okay ? Its been on the list for some time now. Could you please have a look into this and lets us know your inputs/suggestions/comments ? Thank you. - Anshuman -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>