Re: [PATCH] tmpfs: fix shared mempolicy leak
From: Hugh Dickins <hughd@google.com>
Date: 2012-12-05 21:59:23
Also in:
lkml
On Wed, 5 Dec 2012, Tommi Rantala wrote:
2012/12/5 Mel Gorman [off-list ref]:quoted
On Tue, Dec 04, 2012 at 11:24:30PM -0800, Hugh Dickins wrote:quoted
From: Mel Gorman <mgorman@suse.de> Commit 00442ad04a5e ("mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma()") changed get_vma_policy() to raise the refcount on a shmem shared mempolicy; whereas shmem_alloc_page() went on expecting alloc_page_vma() to drop the refcount it had acquired. This deserves a rework: but for now fix the leak in shmem_alloc_page().Thanks Hugh for turning gibber into a patch! Signed-off-by: Mel Gorman <mgorman@suse.de> Tommi, just in case, can you confirm this fixes the problem for you please?Confirmed! No more complaints from kmemleak.
Great, thanks. I'll update the tags and send straight to Linus now. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>