Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170()
From: Hugh Dickins <hughd@google.com>
Date: 2012-06-04 01:19:11
Also in:
lkml
On Sun, 3 Jun 2012, Linus Torvalds wrote:
On Sun, Jun 3, 2012 at 3:17 PM, Hugh Dickins [off-list ref] wrote:quoted
But another strike against that commit: I tried fixing it up to use start_page instead of page at the end, with the worrying but safer locking I suggested at first, with a count of how many times it went there, and how many times it succeeded.You can't use start_page anyway, it might not be a valid page. There's a reson it does that "pfn_valid_within()", methinks.
You wouldn't want me to say that I think you're right, it would impudently suggest that I might conceive of you being wrong. I sigh for your heavy burden.
Anyway, my current plan is to apply your "mm: fix warning in __set_page_dirty_nobuffers" patch - even if it's just a harmless WARN_ON_ONCE(), and revert 5ceb9ce6fe94. Sounds like Dave hit normally hit his problem much before two hours, and it must be even longer now. Ack on that plan?
Sure, ack from me on that plan. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>