Thread (44 messages) 44 messages, 7 authors, 2012-06-04

Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170()

From: Hugh Dickins <hughd@google.com>
Date: 2012-06-01 09:08:37
Also in: lkml

On Fri, 1 Jun 2012, KOSAKI Motohiro wrote:
quoted
  	mlock_migrate_page(newpage, page);
--- 3.4.0+/mm/page-writeback.c	2012-05-29 08:09:58.304806782 -0700
+++ linux/mm/page-writeback.c	2012-06-01 00:23:43.984116973 -0700
@@ -1987,7 +1987,10 @@ int __set_page_dirty_nobuffers(struct pa
  		mapping2 = page_mapping(page);
  		if (mapping2) { /* Race with truncate? */
  			BUG_ON(mapping2 != mapping);
-			WARN_ON_ONCE(!PagePrivate(page)&&
!PageUptodate(page));
+			if (WARN_ON(!PagePrivate(page)&&
!PageUptodate(page)))
+				print_symbol(KERN_WARNING
+				    "mapping->a_ops->writepage: %s\n",
+				    (unsigned
long)mapping->a_ops->writepage);
type mismatch?
I don't think so: I just copied from print_bad_pte().
Probably you're reading "printk" where it's "print_symbol"?
I guess you want %pf or %pF.
I expect there is new-fangled %pMagic that can do it too, yes.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help