On Fri, Jun 1, 2012 at 3:17 PM, Hugh Dickins [off-list ref] wrote:

+       spin_lock_irqsave(&zone->lock, flags);
       for (page = start_page, pfn = start_pfn; page < end_page; pfn++,
                                                                 page++) {

So holding the spinlock (and disabling irqs!) over the whole loop
sounds horrible.

At the same time, the iterators don't seem to require the spinlock, so
it should be possible to just move the lock into the loop, no?

                  Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>