Re: [PATCH 14/18] writeback: control dirty pause time
From: Peter Zijlstra <hidden>
Date: 2011-09-12 10:28:05
Also in:
linux-fsdevel, lkml
On Wed, 2011-09-07 at 10:02 +0800, Wu Fengguang wrote:
quoted
also, do the two other line segments connect on the transition point?I guess we can simply unify the other two formulas into one: } else if (period <= max_pause / 4 && pages_dirtied >= current->nr_dirtied_pause) { current->nr_dirtied_pause = clamp_val( ==> dirty_ratelimit * (max_pause / 2) / HZ, pages_dirtied + pages_dirtied / 8, pages_dirtied * 4); } else if (pause >= max_pause) { current->nr_dirtied_pause = 1 | clamp_val( ==> dirty_ratelimit * (max_pause / 2) / HZ, pages_dirtied / 4, pages_dirtied - pages_dirtied / 8); }
There's still the clamping, that combined with the various conditionals make it very hard to tell if the functions are connected or jump around. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>