Re: [PATCH] memcg: remove unneeded preempt_disable
From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-08-18 07:00:06
Also in:
lkml
From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-08-18 07:00:06
Also in:
lkml
On Wed, 17 Aug 2011 23:50:53 -0700 Greg Thelen [off-list ref] wrote:
Both mem_cgroup_charge_statistics() and mem_cgroup_move_account() were
unnecessarily disabling preemption when adjusting per-cpu counters:
preempt_disable()
__this_cpu_xxx()
__this_cpu_yyy()
preempt_enable()
This change does not disable preemption and thus CPU switch is possible
within these routines. This does not cause a problem because the total
of all cpu counters is summed when reporting stats. Now both
mem_cgroup_charge_statistics() and mem_cgroup_move_account() look like:
this_cpu_xxx()
this_cpu_yyy()
Reported-by: KAMEZAWA Hiroyuki <redacted>
Signed-off-by: Greg Thelen <redacted>Thank you. Acked-by: KAMEZAWA Hiroyuki <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>