Re: 2.6.0-test3-mm1
From: Martin J. Bligh <hidden>
Date: 2003-08-13 20:55:08
Also in:
lkml
--On Wednesday, August 13, 2003 22:18:29 +0200 Sam Ravnborg [off-list ref] wrote:
On Mon, Aug 11, 2003 at 11:26:36AM -0700, George Anzinger wrote:quoted
quoted
that patch sets DEBUG_INFO to y by default, even if whether DEBUG_KERNEL nor KGDB is enabled. The attached patch changes this to enable DEBUG_INFO by default only if KGDB is enabled.Looks good to me, but.... just what does this turn on? Its been a long time and me thinks a wee comment here would help me remember next time.DEBUG_INFO add "-g" to CFLAGS. Main reason to introduce this was that many architectures always use "-g", so a config option seemed more appropriate. I do not agree that this should be dependent on KGDB. To my knowledge -g is useful also without using kgdb.
I have this in my tree (from Dave Hansen). Slightly twisted, but there's no better way I can see. Goes on top of the kgdb patch. M. diff -purN -X /home/mbligh/.diff.exclude 520-queuestat/Makefile 550-config_debug/Makefile
--- 520-queuestat/Makefile 2003-07-28 18:30:57.000000000 -0700
+++ 550-config_debug/Makefile 2003-07-28 19:02:06.000000000 -0700@@ -308,7 +308,7 @@ ifndef CONFIG_FRAME_POINTER CFLAGS += -fomit-frame-pointer endif -ifdef CONFIG_X86_REMOTE_DEBUG +ifdef CONFIG_DEBUG_SYMBOLS CFLAGS += -g endif
diff -purN -X /home/mbligh/.diff.exclude 520-queuestat/arch/i386/Kconfig 550-config_debug/arch/i386/Kconfig
--- 520-queuestat/arch/i386/Kconfig 2003-07-28 18:59:00.000000000 -0700
+++ 550-config_debug/arch/i386/Kconfig 2003-07-28 19:02:06.000000000 -0700@@ -1350,6 +1350,14 @@ config DEBUG_KERNEL Say Y here if you are developing drivers or trying to debug and identify kernel problems. +config DEBUG_SYMBOLS_PROMPT + bool "Get debug symbols (turns on -g)" + depends on DEBUG_KERNEL + +config DEBUG_SYMBOLS + bool + depends on DEBUG_SYMBOLS_PROMPT || X86_REMOTE_DEBUG + config DEBUG_STACKOVERFLOW bool "Check for stack overflows" depends on DEBUG_KERNEL --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>