Martin J. Bligh wrote:

quoted

+#define for_each_valid_zone(zone, zonelist) 		\
+	for (zone = *zonelist->zones; zone; zone++)	\
+		if (current->memblk_binding.bitmask & (1 << zone->zone_pgdat->memblk_id))

Does the compiler optimise the last bit away on non-NUMA?

Nope.

Want to wrap it in #ifdef CONFIG_NUMA_MEMBIND or something?

Not a problem...  I've got some free time this afternoon...  Should only 
take me a few hours to retool the patch to include this change.  ;)

Not sure what the speed impact of this would be, but I'd
rather it was optional, even on NUMA boxen.

Sounds reasonable...  It'll be in the next itteration.

Other than that, looks pretty good.

Glad to hear!

M.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/