Thread (45 messages) 45 messages, 10 authors, 2015-12-11

Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

From: Ulf Hansson <hidden>
Date: 2015-11-25 16:39:01
Also in: linux-mmc, lkml

[...]
quoted
+sdhci_pic32_probe_dts(struct platform_device *pdev,
+                     struct pic32_sdhci_pdata *boarddata)
+{
+       struct device_node *np = pdev->dev.of_node;
+
+       if (!np)
+               return -ENODEV;
+
+       if (of_find_property(np, "no-1-8-v", NULL))
Please don't use this property as it's broken. It has two different
purposes and those are conflicting as discussed here[1].
Realized that I forgot to attach the reference to the discussion, here it is.

[1]
http://comments.gmane.org/gmane.linux.kernel.mmc/32751
You have two options, either invent a new binding which provides
information about which signal voltage that *is* supported, or use the
current existing common MMC dt bindings to override the SDHCI
capabilities register.
[...]

Kind regards
Uffe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help