Thread (45 messages) 45 messages, 10 authors, 2015-12-11

Re: [PATCH 02/14] irqchip: irq-pic32-evic: Add support for PIC32 interrupt controller

From: Marc Zyngier <hidden>
Date: 2015-11-22 11:45:38
Also in: lkml

On Fri, 20 Nov 2015 17:17:14 -0700
Joshua Henderson [off-list ref] wrote:

Joshua, Cristian,
From: Cristian Birsan <cristian.birsan@microchip.com>

This adds support for the EVIC present on a PIC32MZDA.

The following features are supported:
 - DT properties for EVIC and for devices that use interrupt lines
 - persistent and non-persistent interrupt handling
 - Priority, sub-priority and polariy settings for each interrupt line
 - irqdomain support
I haven't reviewed the code yet, but the fact that you allow (and
actually request) the interrupt priorities to be encoded in the DT
raises some concerns:

- Aren't priorities entirely under software control (and hence don't
  belong in DT)?
- More crucially, how do you deal with nested interrupts when you have
  interrupts running at different priorities? Most parts of Linux
  cannot cope with that without additional support.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help