Thread (5 messages) flat view 5 messages, 3 authors, 2007-03-26

Re: [PATCH] Fix a warning in lib-64/dump_tlb.c

From: Florian Fainelli <hidden>
Date: 2007-03-26 21:19:40
Subsystem: mips, the rest · Maintainers: Thomas Bogendoerfer, Linus Torvalds

Forgot including bug.h. Final fix :

Signed-off-by: Florian Fainelli <redacted>
------
diff --git a/arch/mips/lib-64/dump_tlb.c b/arch/mips/lib-64/dump_tlb.c
index 8232900..a2a12ee 100644
--- a/arch/mips/lib-64/dump_tlb.c
+++ b/arch/mips/lib-64/dump_tlb.c
@@ -15,6 +15,7 @@
 #include <asm/mipsregs.h>
 #include <asm/page.h>
 #include <asm/pgtable.h>
+#include <asm/bug.h>

 static inline const char *msk2str(unsigned int mask)
 {
@@ -30,6 +31,7 @@ static inline const char *msk2str(unsigned int mask)
        case PM_64M:    return "64Mb";
        case PM_256M:   return "256Mb";
 #endif
+       default:        BUG();
        }
 }

Le lundi 26 mars 2007, Florian Fainelli a écrit :
quoted hunk ↗ jump to hunk
Hello,

Here is the patch taking into account your remarks. Thanks !

Signed-off-by: Florian Fainelli <redacted>
------
diff --git a/arch/mips/lib-64/dump_tlb.c b/arch/mips/lib-64/dump_tlb.c
index 8232900..a320944 100644
--- a/arch/mips/lib-64/dump_tlb.c
+++ b/arch/mips/lib-64/dump_tlb.c
@@ -30,6 +30,7 @@ static inline const char *msk2str(unsigned int mask)
        case PM_64M:    return "64Mb";
        case PM_256M:   return "256Mb";
 #endif
+       default:        BUG();
        }
 }

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help