Re: [PATCH] Fix a warning in lib-64/dump_tlb.c

Maciej W. Rozycki wrote:

On Fri, 16 Mar 2007, Florian Fainelli wrote:

quoted

This patch suppresses a warning in arch/mips/lib-64/dump_tlb.c

Signed-off-by: Florian Fainelli <redacted>

-----

diff --git a/arch/mips/lib-64/dump_tlb.c b/arch/mips/lib-64/dump_tlb.c
index 8232900..60a87c5 100644
--- a/arch/mips/lib-64/dump_tlb.c
+++ b/arch/mips/lib-64/dump_tlb.c

@@ -30,6 +30,7 @@ static inline const char *msk2str(unsigned int mask)
        case PM_64M:    return "64Mb";
        case PM_256M:   return "256Mb";
 #endif
+       default:        return NULL;
        }
 }

 I guess BUG() would be appropriate here.

AFAICS NULL is wrong, it could cause the printk to crash.


Thiemo