Hi Frieder,

On Tue, Jun 8, 2021 at 7:55 AM Frieder Schrempf
[off-list ref] wrote:

quoted

Frieder's moved adv writes should maybe be inside if (enable) though, with the else write-to-clear as well. Maybe gst sends a stream off?

There's an "if(!enable)" before that and it has "return 0". So it should be fine without "if(enable)".

There is a missing if (state->chip_info->flags &
ADV7180_FLAG_MIPI_CSI2) though. to prevent the csi writes to happen on
non-MIPI ADV7180 parts.

I will fix it when submitting upstream (if I get this to work though :-)