On Tue, 25 Aug 2026 at 09:49 +0200, Linus Walleij wrote:
What kind of "enum" is this that re-assigns 0x00, 0x01 etc to
several enumerators?
Either this is four different enums or you should just do a
series of #defines instead if they are all really coming from
the same place, because using an enum like this does not
make sense: it's like numering pears, apples, oranges
and peaches in the same enum or something.
Also use the UART_ infix as mentioned in the GPIO patch
so you don't need to immediately change it in the next
patch.
Agreed. v2 will use #defines with the UART_ infix in this
patch so the GPIO patch does not rename them.
On Tue, 25 Aug 2026 at 10:12 +0200, Linus Walleij wrote:
You need to CC the TTY maintainers and linux-serial on patches like this,
just keep in mind when resending, thanks!
Will CC linux-serial and the TTY maintainers on v2.
Thanks,
Michael