Re: [PATCH 10/13] HID: ft260: uart: fix active-low RTS/CTS/DTR/DSR polarity

From
Linus Walleij <linusw@kernel.org>
Date
2026-08-25 08:17:04
Also in
linux-gpio, linux-i2c, lkml
Reply to
Michael Zaidman, 2026-08-22
Hi Michael,

thanks for your patch!

On Sat, Aug 22, 2026 at 11:40 PM Michael Zaidman
[off-list ref] wrote:
From: Rio Liu <redacted>

The FT260 modem control GPIOs for RTS, CTS, DTR, and DSR are active-low.
Invert the TIOCMGET sense and the TIOCMSET drive levels for those pins
so userspace ioctl state matches the electrical lines. Leave DCD and RI
unchanged.

Signed-off-by: Rio Liu <redacted>
Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
Isn't this just fixing a patch earlier in the same series?

Just fold it in with the patch adding this.

Note: GPIOlib has it's own polarity inversion handling, when
you rewrite the serial modem control to use the helpers,
the gpio table will include a flag for polarity inversion, and
then you just put it there.

Yours,
Linus Walleij
Thread (52 messages) 52 messages, 5 authors, last reply 2026-09-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help