RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

-----Original Message-----
From: Jiri Kosina <jikos@kernel.org>
Sent: Wednesday, March 5, 2025 4:54 AM
To: Xu, Even <even.xu@intel.com>
Cc: bentiss@kernel.org; srinivas.pandruvada@linux.intel.com; mpearson-
lenovo@squebb.ca; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device
state after S4

On Tue, 4 Mar 2025, Even Xu wrote:

quoted

During S4 retore flow, quickspi device was resetted by driver and
state was changed to RESETTED. It is needed to be change to ENABLED
state after S4 re-initialization finished, otherwise, device will run
in wrong state and HID input data will be dropped.

Um, RESETTED, really?

Sorry, it's my bad, it should be RESET.

In the code the flag is called QUICKI2C_RESETED, but that seems to be
gramatically incorrect as well, right?

Yes, you are right, let me create a patch to correct it.

I'll now apply this as-is because the code is already in, but perhaps renaming the
flag to QUICKI2C_RESET would be in order.

Current patch is still needed, quickspi device init flow is: init -> resetting -> reset -> enabled.
Exiting code in pm restore() callback takes reset operation and puts device into reset state, but forgets
move to enabled state after init flow is done.

Thanks for your suggestion! Let me refine the patch in V2.

Best Regards,
Even Xu 

Thanks,

--
Jiri Kosina
SUSE Labs