Thread (10 messages) flat view 10 messages, 2 authors, 2025-03-07

Re: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

From: Jiri Kosina <jikos@kernel.org>
Date: 2025-03-04 20:54:15
Also in: lkml

On Tue, 4 Mar 2025, Even Xu wrote:
During S4 retore flow, quickspi device was resetted by driver and state
was changed to RESETTED. It is needed to be change to ENABLED state
after S4 re-initialization finished, otherwise, device will run in wrong
state and HID input data will be dropped.
Um, RESETTED, really?

In the code the flag is called QUICKI2C_RESETED, but that seems to be 
gramatically incorrect as well, right?

I'll now apply this as-is because the code is already in, but perhaps 
renaming the flag to QUICKI2C_RESET would be in order.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help