RE: [PATCH v4 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema

From
Biju Das <biju.das.jz@bp.renesas.com>
Date
2023-12-09 16:38:09
Also in
linux-devicetree, linux-pm, linux-renesas-soc
Reply to
Krzysztof Kozlowski, 2023-12-09
Hi Krzysztof Kozlowski,

-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Saturday, December 9, 2023 4:08 PM
Subject: Re: [PATCH v4 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062
to json-schema

On 09/12/2023 16:41, Biju Das wrote:
quoted
quoted
Why disabling? Drop all statuses from all your binding examples.
quoted
quoted
Where are gpio-controller and cells? For this node and for parent?
Why this example is incomplete?
Currently I don't see any driver is using this compatible other than
MFD.

Open the MFD so you will see it...
Actually, found the driver and tested GPIOs, For input gpio, I can see
the sd1_pwr_sel values are toggled during card insert/removal.
For outout gpio,
System is entering into reset mode, if I set output-low in DT. So set
Init state as output-high to avoid reset.

drivers/pinctrl/pinctrl-da9062.c
Anyway there is a GPIO child node and driver which binds to it. What's its
purpose in such case?

The pinctrl-da9062driver is instantiated from the parent, since there is a
GPIO child node with matching compatible.

MFD_CELL_OF("da9062-gpio", da9062_gpio_resources, NULL, 0, 0,
		    "dlg,da9062-gpio"),


root@smarc-rzg2ul:~# cat /sys/kernel/debug/gpio | grep da9062 -A5
gpiochip1: GPIOs 664-668, parent: platform/da9062-gpio, da9062-gpio, can sleep:
 gpio-665 (                    |SD0_PWR_SEL         ) in  lo
 gpio-666 (                    |SD1_PWR_SEL         ) in  lo
 gpio-667 (                    |SW_ET0_EN#          ) in  hi
 gpio-668 (                    |PMIC_PGOOD          ) out hi
root@smarc-rzg2ul:~#

Thread (15 messages) 15 messages, 2 authors, last reply 2023-12-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help