Thread (20 messages) 20 messages, 5 authors, 2023-10-02

Re: [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors

From: Duje Mihanović <duje.mihanovic@skole.hr>
Date: 2023-10-01 18:40:19
Also in: linux-arm-kernel, linux-gpio, linux-spi, linux-usb, lkml

On 10/1/2023 4:32 PM, Andy Shevchenko wrote:
quoted
+       pxa_ohci->usb_host = gpiod_get_optional(&pdev->dev, "usb-host", GPIOD_OUT_LOW);
+       if (IS_ERR(pxa_ohci->usb_host))
+               dev_warn(&pdev->dev, "failed to get USB host GPIO with %pe\n",
+                               pxa_ohci->usb_host);
Since you are using _optional() API, you need to bail out on the error
case and replace dev_warn() by dev_err(). I guess I already commented
on this. What is the rationale to not follow my comment?
I must have missed it, sorry about that. I'll be sure to do so in v5.

Regards,
Duje
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help