Thread (20 messages) 20 messages, 5 authors, 2023-10-02

Re: [PATCH RFC v4 2/6] ARM: pxa: Convert Spitz LEDs to GPIO descriptors

From: Andy Shevchenko <hidden>
Date: 2023-10-01 14:35:25
Also in: linux-arm-kernel, linux-gpio, linux-spi, linux-usb, lkml

On Sun, Oct 1, 2023 at 5:13 PM Duje Mihanović [off-list ref] wrote:
Sharp's Spitz board still uses the legacy GPIO interface for configuring
its two onboard LEDs.

Convert them to use the GPIO descriptor interface.
...
 static void __init spitz_leds_init(void)
 {
+       gpiod_add_lookup_table(&spitz_led_gpio_table);
        platform_device_register(&spitz_led_device);
+       spitz_gpio_leds[0].gpiod = gpiod_get_index(&spitz_led_device.dev,
+                       NULL, 0, GPIOD_ASIS);
+       spitz_gpio_leds[1].gpiod = gpiod_get_index(&spitz_led_device.dev,
+                       NULL, 1, GPIOD_ASIS);
 }
What's the point of keeping a lookup table after we got descriptors out of it?

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help