Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings
From: Benjamin Tissoires <bentiss@kernel.org>
Date: 2023-08-21 13:56:10
Also in:
lkml
On Aug 21 2023, Andy Shevchenko wrote:
On Mon, Aug 21, 2023 at 12:27:22PM +0200, Benjamin Tissoires wrote:quoted
On Mon, Aug 21, 2023 at 12:19 PM Benjamin Tissoires [off-list ref] wrote:quoted
On Mon, Aug 21, 2023 at 11:35 AM Andy Shevchenko [off-list ref] wrote:quoted
On Mon, Aug 21, 2023 at 12:34:30PM +0300, Andy Shevchenko wrote:quoted
On Mon, Aug 21, 2023 at 10:51:04AM +0200, Benjamin Tissoires wrote:quoted
On Aug 21 2023, Andy Shevchenko wrote:...quoted
quoted
quoted
quoted
quoted
Long story short, I'm not able to test it right now (and I got quite some backlog as you can imagine). IIRC the code was fine, so I think we can just take the series as is, and work on the quirks (if any) later.Thank you! The thing that might be broken is interrupts handling. If that works, I'm pretty confident with the rest.I.o.w. first 5 patches to test is already 98% of guarantee that everything is fine.Actually I applied you series locally, and applied Danny's patches on top, and I could run your series in qemu with the cp2112 as USB passthrough. Everything is working fine, so I can take this one just now.I've pushed the series to for-6.6/cp2112, but for some reasons, b4 doesn't seem to believe the series is the one you submitted. Would you mind double checking on your side if everything is good? https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-6.6/cp2112Everything is fine as far as I can tell.
Great, thanks for double checking. Cheers, Benjamin
-- With Best Regards, Andy Shevchenko